Transfer-learning allow additional fragtypes #421
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschwoer
approved these changes
Jan 10, 2025
| self._train_fraction + self._validation_fraction + self._test_fraction | ||
| <= 1.0 | ||
| ), "The sum of the train, validation and test fractions should be less than or equal to 1.0" | ||
| super().__init__(mask_modloss, device, self.charged_frag_types) |
Collaborator
There was a problem hiding this comment.
I would prefer calling this init still at the top..
def ...(..):
charged_frag_types = (
get_charged_frag_types(fragment_types, max_charge)
if fragment_types
else None
)
super().__init__(mask_modloss, device, charged_frag_types)
self.charged_frag_types = charged_frag_types
...
I did not find a proper resource, but I feel the parent init should be called "as early as possible"
https://stackoverflow.com/a/77975817
| @@ -0,0 +1,480 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
A small initial description of what the purpose of this nb is would be nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the functionality introduced in peptdeep PR.
To allow finetuning a pretrained model to be able to predict different number of charged_frag_types while using the pretrained backbone as a starting point for the weights.